git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/7] gitweb: Use 'local $/ = undef;' before 'print <$fd>;'

From
Jakub Narebski <jnareb@gmail.com>
Date
Aug 26, 2006, 17:14 UTC
Message-ID
<11566124673653-git-send-email-jnareb@gmail.com>
In-Reply-To
<1156612392716-git-send-email-jnareb@gmail.com>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
 gitweb/gitweb.perl |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 093deab..eae83e6 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2017,6 +2017,7 @@ sub git_project_list {
 	if (-f $home_text) {
 		print "<div class=\"index_include\">\n";
 		open (my $fd, $home_text);
+		local $/ = undef;
 		print <$fd>;
 		close $fd;
 		print "</div>\n";
@@ -2395,11 +2396,10 @@ sub git_blob_plain {
 
 	print $cgi->header(-type => "$type",
 	                   -content_disposition => "inline; filename=\"$save_as\"");
-	undef $/;
 	binmode STDOUT, ':raw';
+	local $/ = undef;
 	print <$fd>;
 	binmode STDOUT, ':utf8'; # as set at the beginning of gitweb.cgi
-	$/ = "\n";
 	close $fd;
 }
 
@@ -2585,6 +2585,7 @@ sub git_snapshot {
 	open my $fd, "-|", "$GIT tar-tree $hash \'$project\' | $command" or
 		die_error(undef, "Execute git-tar-tree failed.");
 	binmode STDOUT, ':raw';
+	local $/ = undef;
 	print <$fd>;
 	binmode STDOUT, ':utf8'; # as set at the beginning of gitweb.cgi
 	close $fd;
-- 
1.4.1.1
Previous: Jakub NarebskiNext: Jakub Narebski
Message 6 of 11 in “gitweb: Cleanups, fixes and small improvements”
  1. 0/7 gitweb: Cleanups, fixes and small improvementsJakub Narebski, Aug 26, 2006
  2. 1/7 gitweb: Restore old git_blame using git-annotate under "annotate"Jakub Narebski, Aug 26, 2006
  3. 2/7 gitweb: Remove workaround for git-diff bug fixed in f82cd3cJakub Narebski, Aug 26, 2006
  4. 3/7 gitweb: Improve comments about gitweb features configurationJakub Narebski, Aug 26, 2006
  5. 4/7 gitweb: Fix typo in git_patchset_bodyJakub Narebski, Aug 26, 2006
  6. 5/7 gitweb: Use 'local $/ = undef;' before 'print <$fd>;'Jakub Narebski, Aug 26, 2006
  7. 6/7 gitweb: blobs defined by non-textual hash ids can be cachedJakub Narebski, Aug 26, 2006
  8. 7/7 gitweb: Always link to plain version of the blob in git_blob.Jakub Narebski, Aug 26, 2006
  9. Junio C HamanoAug 26, 2006
  10. Jakub NarebskiAug 26, 2006
  11. Jakub NarebskiAug 27, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.