Re: [PATCH/RFC] gitweb: Add title attribute with unshortened value for table cells

From: Jakub Narebski <jnareb@gmail.com>
Date: Jun 20, 2006, 09:48 UTC
Message-ID: <e78g90$40u$1@sea.gmane.org>
In-Reply-To: <7vd5d4chmg.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 8 quoted lines

> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> Doesn't work well with values outside us-ascii, but that might be
>> considered web browser bug (misfeature), not a bug in gitweb.
> 
> That's sad.
> 
> Are you sure about it?

Now I see I was wrong.

> What does start_td({-title=>"blah"}) produce? <td title="blah">?
> If so, is http://members.cox.net/junkio/t.html close to what you
> are trying to achieve here?

Yes, that is what I tried to achieve. Using CGI to set attributes was to quote characters which cannot be in double quited attribute values, i.e. change '"' to '"' or '"'. I don't know what start_td did with \"o character (Perl v5.8.6, CGI::VERSION=3.05).

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git