Re: [PATCH/RFC] gitweb: Add title attribute with unshortened value for table cells

From: Timo Hirvonen <tihirvon@gmail.com>
Date: Jun 20, 2006, 10:57 UTC
Message-ID: <20060620135750.7880c62d.tihirvon@gmail.com>
In-Reply-To: <e78gun$65s$1@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> wrote:

Show 21 quoted lines

> Timo Hirvonen wrote:
> 
> > http://onion.dynserv.net/git/gitweb.cgi
> > 
> > Global symbol "$path" requires explicit package name at
> > /var/www/localhost/htdocs/git/gitweb.cgi line 1521.
> > Execution of /var/www/localhost/htdocs/git/gitweb.cgi aborted due to
> > compilation errors.
> > 
> > The line is:
> > 
> > $file =~ m#^/# or $file = "$projectroot/$path/$file";
> > 
> > $path seems to be undefined.  I don't understand perl very well so I
> > can't fix it.
> 
> Temporary fix is in:
>  
>   "[PATCH] Fix: Support for the standard mime.types map in gitweb"
>   (Message-Id: <11507843541678-git-send-email-jnareb@gmail.com>)
>     http://permalink.gmane.org/gmane.comp.version-control.git/22172

Seems to work now. I also enabled blame and it works too. But I noticed that the search is sometimes broken. If you click a "blob" link and then try to search something gitweb will complain:

    403 Forbidden - Unknown commit object.

"h" parameter is blob, not commit. Shouldn't the h parameter be set to HEAD always when searching? Searching starts at h so the search results vary:

http://onion.dynserv.net/git/gitweb.cgi?p=cmus.git&a=search&h=HEAD&s=pickaxe%3Atheme

http://onion.dynserv.net/git/gitweb.cgi?p=cmus.git&a=search&h=fd2d983d51858e25cc71b14b59c787e1683ba7c5&s=pickaxe%3Atheme

-- 
http://onion.dynserv.net/~timo/