[PATCH/RFC] gitweb: Add title attribute with unshortened value for table cells
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jun 20, 2006, 08:12 UTC
- Message-ID
- <200606201012.31684.jnareb@gmail.com>
This allows to see full, unshortened value on mouseover using 'title' attribute for <td> element. For now it means only author name and project owner name.
Ugly solution using $cgi->start_td({-title => VALUE})Doesn't work well with values outside us-ascii, but that might be considered web browser bug (misfeature), not a bug in gitweb.
--- The idea is to have full value available on mouseover, be it commit title, author of the commit, project owner, tag name/title or project description. For now only author name and project owner name are implemented, and implementation is ugly and results is not perfect.
gitweb/gitweb.cgi | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
b72280ac4649d54375732de771f7d92c7d350258
diff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.cgi index 1b254df..9a09b20 100755 --- a/gitweb/gitweb.cgi +++ b/gitweb/gitweb.cgi @@ -887,7 +887,7 @@ sub git_project_list { $alternate ^= 1; print "<td>" . $cgi->a({-href => "$my_uri?" . esc_param("p=$pr->{'path'};a=summary"), -class => "list"}, esc_html($pr->{'path'})) . "</td>\n" . "<td>$pr->{'descr'}</td>\n" . - "<td><i>" . chop_str($pr->{'owner'}, 15) . "</i></td>\n"; + $cgi->start_td({-title => $pr->{'owner'}}) . chop_str($pr->{'owner'}, 15) . "</i></td>\n"; my $colored_age; if ($pr->{'commit'}{'age'} < 60*60*2) { $colored_age = "<span style =\"color: #009900;\"><b><i>$pr->{'commit'}{'age_string'}</i></b></span>"; @@ -1057,7 +1057,7 @@ sub git_summary { $ref = " <span class=\"tag\">" . esc_html($refs->{$commit}) . "</span>"; } print "<td><i>$co{'age_string'}</i></td>\n" . - "<td><i>" . esc_html(chop_str($co{'author_name'}, 10)) . "</i></td>\n" . + $cgi->start_td({-title => $co{'author_name'}}) . esc_html(chop_str($co{'author_name'}, 10)) . "</i></td>\n" . "<td>"; if (length($co{'title_short'}) < length($co{'title'})) { print $cgi->a({-href => "$my_uri?" . esc_param("p=$project;a=commit;h=$commit"), -class => "list", -title => "$co{'title'}"}, @@ -2306,7 +2306,7 @@ sub git_history { } $alternate ^= 1; print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" . - "<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 3)) . "</i></td>\n" . + $cgi->start_td({-title => $co{'author_name'}}) . esc_html(chop_str($co{'author_name'}, 15, 3)) . "</i></td>\n" . "<td>" . $cgi->a({-href => "$my_uri?" . esc_param("p=$project;a=commit;h=$commit"), -class => "list"}, "<b>" . esc_html(chop_str($co{'title'}, 50)) . "$ref</b>") . "</td>\n" . "<td class=\"link\">" . @@ -2396,7 +2396,7 @@ sub git_search { } $alternate ^= 1; print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" . - "<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 5)) . "</i></td>\n" . + $cgi->start_td({-title => $co{'author_name'}}) . esc_html(chop_str($co{'author_name'}, 15, 5)) . "</i></td>\n" . "<td>" . $cgi->a({-href => "$my_uri?" . esc_param("p=$project;a=commit;h=$co{'id'}"), -class => "list"}, "<b>" . esc_html(chop_str($co{'title'}, 50)) . "</b><br/>"); my $comment = $co{'comment'}; @@ -2449,7 +2449,7 @@ sub git_search { } $alternate ^= 1; print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" . - "<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 5)) . "</i></td>\n" . + $cgi->start_td({-title => $co{'author_name'}}) . esc_html(chop_str($co{'author_name'}, 15, 5)) . "</i></td>\n" . "<td>" . $cgi->a({-href => "$my_uri?" . esc_param("p=$project;a=commit;h=$co{'id'}"), -class => "list"}, "<b>" . esc_html(chop_str($co{'title'}, 50)) . "</b><br/>"); @@ -2537,7 +2537,7 @@ sub git_shortlog { } $alternate ^= 1; print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" . - "<td><i>" . esc_html(chop_str($co{'author_name'}, 10)) . "</i></td>\n" . + $cgi->start_td({-title => $co{'author_name'}}) . esc_html(chop_str($co{'author_name'}, 10)) . "</i></td>\n" . "<td>"; if (length($co{'title_short'}) < length($co{'title'})) { print $cgi->a({-href => "$my_uri?" . esc_param("p=$project;a=commit;h=$commit"), -class => "list", -title => "$co{'title'}"},
-- 1.3.0