Re: [PATCH/RFC] gitweb: Add title attribute with unshortened value for table cells

From: Junio C Hamano <junkio@cox.net>
Date: Jun 20, 2006, 09:15 UTC
Message-ID: <7vd5d4chmg.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200606201012.31684.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> Doesn't work well with values outside us-ascii, but that might be
> considered web browser bug (misfeature), not a bug in gitweb.

That's sad.

Are you sure about it?

What does start_td({-title=>"blah"}) produce? <td title="blah">? If so, is http://members.cox.net/junkio/t.html close to what you are trying to achieve here?

>  		      "<td>$pr->{'descr'}</td>\n" .
> -		      "<td><i>" . chop_str($pr->{'owner'}, 15) . "</i></td>\n";
> +		      $cgi->start_td({-title => $pr->{'owner'}}) . chop_str($pr->{'owner'}, 15) . "</i></td>\n";

Where did the opening <i> go? Not that I care about italics, since I think this should all be done with stylesheet, but I do care about unbalanced pairs.

BTW, I haven't nailed down the procedure to update the kernel.org gitweb installations (I suspect the burden is on me since Kay orphaned gitweb onto me).

I wonder if there is somebody who is willing to run gitweb from the "next" branch on some public site, so that I can be reasonably confident before breaking one of the most important infrastructure of the kernel development? Volunteers?