git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Speedup prefixcmp() common case

From
MCMarco Costalba <mcostalba@gmail.com>
Date
Dec 29, 2007, 20:14 UTC
Message-ID
<e5bfff550712291214p7554ea52o875667906ce1a22d@mail.gmail.com>
In-Reply-To
<7v63yhb8kf.fsf@gitster.siamese.dyndns.org>
On Dec 29, 2007 8:32 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
>
> Why isn't it like this?
>
>         if (!prefix[1])
>
well, what about if prefix == NULL ?

Actually I didn't checked if strncmp() checks for NULL pointers before to proceed, if this is the case I managed to keep the same semantic.

You could say "Why, lazy you, didn't you checked if strncmp() checks for NULL pointers? "...but I hope you are foregiving ;-)

Thanks Marco

Previous: Junio C HamanoNext: Junio C Hamano
Message 18 of 20 in “Speedup prefixcmp() common case”
  1. Speedup prefixcmp() common caseMarco Costalba, Dec 29, 2007
  2. Optimize prefixcmp()Johannes Schindelin, Dec 29, 2007
  3. Marco CostalbaDec 29, 2007
  4. Johannes SchindelinDec 29, 2007
  5. Marco CostalbaDec 29, 2007
  6. Marco CostalbaDec 30, 2007
  7. Pierre HabouzitDec 30, 2007
  8. Pierre HabouzitDec 30, 2007
  9. Marco CostalbaDec 30, 2007
  10. Marco CostalbaDec 30, 2007
  11. Johannes SchindelinDec 30, 2007
  12. Andy ParkinsDec 29, 2007
  13. Junio C HamanoDec 30, 2007
  14. René ScharfeJan 2, 2008
  15. Junio C HamanoJan 2, 2008
  16. René ScharfeJan 3, 2008
  17. Junio C HamanoDec 29, 2007
  18. Marco CostalbaDec 29, 2007
  19. Junio C HamanoDec 30, 2007
  20. Marco CostalbaDec 29, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.