git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Optimize prefixcmp()

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 29, 2007, 22:15 UTC
Message-ID
<Pine.LNX.4.64.0712292307210.14355@wbgn129.biozentrum.uni-wuerzburg.de>
In-Reply-To
<e5bfff550712291239y5648b923y8d332d9c40a8c97b@mail.gmail.com>
Hi,
On Sat, 29 Dec 2007, Marco Costalba wrote:
> What your patch does not seem to avoid is a segfault if prefix or str 
> are NULL pointers.

I am quite certain that it is not allowed to pass NULL pointers to strcmp, and even if it was, I maintain that it is bad style.

FWIW the test suite seems to agree with me, as it passes with my patch.

However, since you already seem to have a profiling setup ready, I would be interested in some numbers, i.e. if this patch is faster for you or slower, or shows no effect at all.

Ciao, Dscho

Previous: Marco CostalbaNext: Marco Costalba
Message 4 of 20 in “Speedup prefixcmp() common case”
  1. Speedup prefixcmp() common caseMarco Costalba, Dec 29, 2007
  2. Optimize prefixcmp()Johannes Schindelin, Dec 29, 2007
  3. Marco CostalbaDec 29, 2007
  4. Johannes SchindelinDec 29, 2007
  5. Marco CostalbaDec 29, 2007
  6. Marco CostalbaDec 30, 2007
  7. Pierre HabouzitDec 30, 2007
  8. Pierre HabouzitDec 30, 2007
  9. Marco CostalbaDec 30, 2007
  10. Marco CostalbaDec 30, 2007
  11. Johannes SchindelinDec 30, 2007
  12. Andy ParkinsDec 29, 2007
  13. Junio C HamanoDec 30, 2007
  14. René ScharfeJan 2, 2008
  15. Junio C HamanoJan 2, 2008
  16. René ScharfeJan 3, 2008
  17. Junio C HamanoDec 29, 2007
  18. Marco CostalbaDec 29, 2007
  19. Junio C HamanoDec 30, 2007
  20. Marco CostalbaDec 29, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.