From: Marco Costalba <mcostalba@gmail.com>
Date: Sat, 29 Dec 2007 20:14:55 GMT
Subject: Re: [PATCH] Speedup prefixcmp() common case
Message-ID: <e5bfff550712291214p7554ea52o875667906ce1a22d@mail.gmail.com>
In-Reply-To: <7v63yhb8kf.fsf@gitster.siamese.dyndns.org>

On Dec 29, 2007 8:32 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> Why isn't it like this?
>
>         if (!prefix[1])
>

well, what about if prefix == NULL ?

Actually I didn't checked if strncmp() checks for NULL pointers before
to proceed, if this is the case I managed to keep the same semantic.

You could say "Why, lazy you, didn't you checked if strncmp() checks
for NULL pointers? "...but I hope you are foregiving ;-)

Thanks
Marco