Re: [PATCH] Speedup prefixcmp() common case
"Marco Costalba" <mcostalba@gmail.com> writes:
Show 12 quoted lines
> diff --git a/git-compat-util.h b/git-compat-util.h
> index 79eb10e..e26b684 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -398,6 +398,10 @@ static inline int sane_case
>
> static inline int prefixcmp(const char *str, const char *prefix)
> {
> + // shortcut common case of a single char prefix
> + if (prefix && *(prefix + 1) == '\0' && str)
> + return *str - *prefix;
> +Why isn't it like this?
if (!prefix[1])
return *str - *prefix;
Show 5 quoted lines
> return strncmp(str, prefix, strlen(prefix));
> }
>
> --
> 1.5.4.rc2-dirty
Junio C Hamano <gitster@pobox.com>