Re: git-format-patch possible regressions

From: Marco Costalba <mcostalba@gmail.com>
Date: May 25, 2006, 20:21 UTC
Message-ID: <e5bfff550605251321t7378b427p68ffe2e16a54b3ff@mail.gmail.com>
In-Reply-To: <7vhd3dubd9.fsf@assigned-by-dhcp.cox.net>

Show 7 quoted lines

> > Both regressions brake qgit. The first one is easy to fix (--signoff  --> -s)
>
> I do not think -s does what you want.  It means "do not generate
> diff" to the diff family, but format-patch overrides it and
> forces generating patch+stat output, so you do not see what it
> is doing.
>

Sorry, I was fooled by git-format-patch.txt documentation.

Show 9 quoted lines

> > 2) Unhandled ranges list
> >
> > The second one is not so easy.
>
> This is a real regression; I was hoping Porcelain writers were
> paying attention of what are coming, but obviously the
> description in "What's in git.git" messages and discussion on
> the list were not detailed enough.  My apologies.
>

Sorry also for this, normally I read "What's in git.git" but perhaps I missed this.

Show 6 quoted lines

>
> As an easy alternative, we could give --start-number=<n> to
> format-patch so that you can do the iteration yourself instead
> of having format-patch to iterate over the list.
>
>

You beat me for few minutes ;-)

     Marco