Re: git-format-patch possible regressions

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 25, 2006, 22:18 UTC
Message-ID: <Pine.LNX.4.63.0605260014340.13003@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <Pine.LNX.4.63.0605252338530.31700@wbgn013.biozentrum.uni-wuerzburg.de>

Hi,

On Thu, 25 May 2006, Johannes Schindelin wrote:

Show 12 quoted lines

> @@ -193,6 +201,11 @@ int cmd_format_patch(int argc, const cha
>  	}
>  	argc = j;
>  
> +	if (start_number >= 0)
> +		numbered = 1;
> +	else if (numbered)
> +		start_number = 1;
> +
>  	if (numbered && keep_subject < 0)
>  		die ("-n and -k are mutually exclusive.");
>

Thinking about this again, it makes more sense not to imply --numbered:

	if (numbered && start_number < 0)
		start_number = 1;

Ciao, Dscho