git-format-patch possible regressions

A couple of possible regressions:

1) Unreconized --signoff option

$ git --version git version 1.3.3.ged90 $ git-format-patch -s HEAD^..HEAD 0001-cat-file-document-p-option.txt $ git-format-patch --signoff HEAD^..HEAD fatal: unrecognized argument: --signoff

2) Unhandled ranges list

$ git --version git version 1.3.3.ged90 $ git-format-patch -s HEAD^..HEAD HEAD^^..HEAD^ 0001-cat-file-document-p-option.txt

$ git --version git version 1.3.3.gf205 git checkout -b test 51ce34b9923d9b119ac53414584f80e05520abea $ git-format-patch HEAD^..HEAD HEAD^^..HEAD^ 0001-Builtin-git-show-branch.txt 0002-Builtin-git-apply.txt

Both regressions brake qgit. The first one is easy to fix (--signoff --> -s) The second one is not so easy. It is use to format a patch series starting from a mouse selected multiple revisions. Note that the revisions could be not consecutive. Note also that looping git-format-patch for each revision does not updates patch number that always stay at 0001.

Feeding all the selected revisions in one go in the form git-format-patch sel1^..sel1 sel2^..sel2 ........ seln^..seln is the only way I have found to:

1) create a patch series of (randomly) selected revisions

2) increment patch numbers for each patch

   Marco