git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] format-patch: move range/inter diff at the end of a single patch output

From
DSDragan Simic <dsimic@manjaro.org>
Date
May 30, 2024, 20:05 UTC
Message-ID
<e01506f4c8129318dbcba553d7c90b13@manjaro.org>
In-Reply-To
<xmqqplt41yk4.fsf@gitster.g>
On 2024-05-29 16:29, Junio C Hamano wrote:
Show 24 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
> 
>> On Tue, May 28, 2024 at 09:50:43AM -0700, Junio C Hamano wrote:
>>> Patrick Steinhardt <ps@pks.im> writes:
>>> 
>>> > Yeah, that's definitely better. Whether it's preferable over having it
>>> > after the signature separator I don't know. I personally liked that
>>> > version better, but can totally see why others may not like it.
>>> 
>>> I do not think anybody posted a version that writes inter/range diff
>>> ater the signature mark.
>> 
>> No, I'm talking about the version that you hand crafted initially and
>> that kicked off this topic.
> 
> Ah, https://lore.kernel.org/git/xmqqh6ep1pwz.fsf_-_@gitster.g/ I
> forgot all about it already ;-).
> 
>> ... I just don't have a strong preference between the old and
>> new formats by now. If you or others feel strongly I don't mind at all
>> if this patch lands.
> 
> Let's scrap it then.  I do not think a single-patch topic happens
> all that often anyway.

Hmm. Actually, I find it logical and I don't think it should be scrapped. As I wrote already, I find range diffs as really long footnotes, and placing them at the end of "documents" seems like a logical choice to me.

Previous: Junio C HamanoNext: Junio C Hamano
Message 13 of 18 in “give range-diff at the end of single patch output”
  1. 0/2 give range-diff at the end of single patch outputJunio C Hamano, May 23, 2024
  2. 1/2 show_log: factor out interdiff/range-diff generationJunio C Hamano, May 23, 2024
  3. 2/2 format-patch: move range/inter diff at the end of a single patch outputJunio C Hamano, May 23, 2024
  4. Patrick SteinhardtMay 24, 2024
  5. Junio C HamanoMay 24, 2024
  6. Patrick SteinhardtMay 27, 2024
  7. Dragan SimicMay 27, 2024
  8. Junio C HamanoMay 27, 2024
  9. Patrick SteinhardtMay 28, 2024
  10. Junio C HamanoMay 28, 2024
  11. Patrick SteinhardtMay 29, 2024
  12. Junio C HamanoMay 29, 2024
  13. Dragan SimicMay 30, 2024
  14. 2/2 format-patch: move range/inter diff at the end of a single patch outputJunio C Hamano, May 24, 2024
  15. Dragan SimicMay 23, 2024
  16. Junio C HamanoMay 23, 2024
  17. Dragan SimicMay 23, 2024
  18. Junio C HamanoMay 24, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.