Re: [PATCH 2/2] format-patch: move range/inter diff at the end of a single patch output

From: Patrick Steinhardt <ps@pks.im>
Date: May 28, 2024, 13:27 UTC
Message-ID: <ZlXbxzFOJ8gVv7r5@tanuki>
In-Reply-To: <xmqqsey39mmt.fsf@gitster.g>

On Mon, May 27, 2024 at 10:43:06AM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > The machine can cope alright. But I think that it's way harder to parse
> > for a human if there is no clear visual delimiter between the diff and
> > the interdiff. And "Interdiff" isn't quite ideal in my opinion because
> > it is text, only, and may be quite easy to miss if it follows a long
> > diff.
> 
> Apparently our messages crossed.   See <xmqqed9qke3k.fsf_-_@gitster.g>
> that takes advantage of the fact that "the machine can cope alright"
> with an extra blank line ;-).  The message is its own demonstration.
> 
> Thanks.

Yeah, that's definitely better. Whether it's preferable over having it after the signature separator I don't know. I personally liked that version better, but can totally see why others may not like it.

Hm. By now I've gotten a bit indifferent, to be honest. I'm not a 100% sure whether it's an improvement or not, but I don't have a strong opinion either way.

Patrick