Re: [PATCH 0/2] give range-diff at the end of single patch output

From: Dragan Simic <dsimic@manjaro.org>
Date: May 23, 2024, 23:35 UTC
Message-ID: <8b08ccd0953aec5a2fcb3a61bc86c32d@manjaro.org>
In-Reply-To: <xmqq34q8qfek.fsf@gitster.g>

On 2024-05-24 01:25, Junio C Hamano wrote:

Show 15 quoted lines

> Dragan Simic <dsimic@manjaro.org> writes:
> 
>> Hmm...  I think this should be made configurable, with the current
>> behavior being the default.  Without that, we could easily disrupt
>> many people's workflows, because the power of "muscle memory" is
>> often really strong.
> 
> I would view this more like "Porcelain layers reserve the right to
> change the behaviour to suit human-end-user needs, without having to
> complicate the system with extra configuration knobs."
> 
> But if other people want to do a follow-up patch to cleanly add such
> a configuration, I would not object to it.  The main desire of this
> patch is *not* to make the option to have range-diff at the end of a
> single patch "series" available, but to make that the default.

I see. Personally, I find the range diffs placed _after_ the actual patches more pleasant, but I'm just concerned about other people that might not like such an arrangement that much.

To me, a range diff is like an additional description of the actual patch, or like a really long footnote, so to me it makes more sense to put it at the end of the "document". Sometimes I don't even want or need to look at that footnote, so not needing to scroll down is another plus.