git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] give range-diff at the end of single patch output

From
DSDragan Simic <dsimic@manjaro.org>
Date
May 23, 2024, 23:22 UTC
Message-ID
<83436db5996b129032c2869f331980d0@manjaro.org>
In-Reply-To
<20240523225007.2871766-1-gitster@pobox.com>
On 2024-05-24 00:50, Junio C Hamano wrote:
Show 15 quoted lines
> When running "format-patch" on a multiple patch series, the output
> coming from "--interdiff" and "--range-diff" options is inserted
> after the "shortlog" list of commits and the overall diffstat.
> 
> The idea is that shortlog/diffstat are shorter and with denser
> information content, which gives a better overview before the
> readers dive into more details of range/inter diff.
> 
> When working on a single patch, however, we stuff the inter/range
> diff output before the actual patch, next to the diffstat.  This
> pushes down the patch text way down with inter/range diff output,
> distracting readers.
> 
> Move the inter/range diff output to the very end of the output,
> after all the patch text is shown.

Hmm... I think this should be made configurable, with the current behavior being the default. Without that, we could easily disrupt many people's workflows, because the power of "muscle memory" is often really strong.

If it were just about moving a few lines up or down, making it configurable wouldn't make much sense, but with moving this large chunks of text... It's a different story.

Previous: Junio C HamanoNext: Junio C Hamano
Message 15 of 18 in “give range-diff at the end of single patch output”
  1. 0/2 give range-diff at the end of single patch outputJunio C Hamano, May 23, 2024
  2. 1/2 show_log: factor out interdiff/range-diff generationJunio C Hamano, May 23, 2024
  3. 2/2 format-patch: move range/inter diff at the end of a single patch outputJunio C Hamano, May 23, 2024
  4. Patrick SteinhardtMay 24, 2024
  5. Junio C HamanoMay 24, 2024
  6. Patrick SteinhardtMay 27, 2024
  7. Dragan SimicMay 27, 2024
  8. Junio C HamanoMay 27, 2024
  9. Patrick SteinhardtMay 28, 2024
  10. Junio C HamanoMay 28, 2024
  11. Patrick SteinhardtMay 29, 2024
  12. Junio C HamanoMay 29, 2024
  13. Dragan SimicMay 30, 2024
  14. 2/2 format-patch: move range/inter diff at the end of a single patch outputJunio C Hamano, May 24, 2024
  15. Dragan SimicMay 23, 2024
  16. Junio C HamanoMay 23, 2024
  17. Dragan SimicMay 23, 2024
  18. Junio C HamanoMay 24, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.