git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 28/28] makes upload_pack void

From
Nikolai Weibull <now@bitwi.se>
Date
Aug 14, 2006, 22:45 UTC
Message-ID
<dbfc82860608141545s3e75457eo4be1201395e24354@mail.gmail.com>
In-Reply-To
<Pine.LNX.4.63.0608141340060.19383@chino.corp.google.com>
On 8/14/06, David Rientjes <rientjes@google.com> wrote:
> Makes upload_pack void and removes conditional return.
> -static int upload_pack(void)
> +static void upload_pack(void)

I don't know for sure, but I'm guessing the intention was to be able to return a failing code /if/ there ever was a condition where upload_pack() would fail, e.g., if send_ref() would return a status code instead of die():ing if it can't parse the given sha1. In a future libification, the change of return type may have to be reverted.

  nikolai
Previous: David RientjesNext: David Rientjes
Message 2 of 4 in “makes upload_pack void”
  1. 28/28 makes upload_pack voidDavid Rientjes, Aug 14, 2006
  2. Nikolai WeibullAug 14, 2006
  3. David RientjesAug 14, 2006
  4. Nikolai WeibullAug 14, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.