From: Nikolai Weibull <now@bitwi.se>
Date: Mon, 14 Aug 2006 22:45:20 GMT
Subject: Re: [PATCH 28/28] makes upload_pack void
Message-ID: <dbfc82860608141545s3e75457eo4be1201395e24354@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.63.0608141340060.19383@chino.corp.google.com>

On 8/14/06, David Rientjes <rientjes@google.com> wrote:
> Makes upload_pack void and removes conditional return.

> -static int upload_pack(void)
> +static void upload_pack(void)

I don't know for sure, but I'm guessing the intention was to be able
to return a failing code /if/ there ever was a condition where
upload_pack() would fail, e.g., if send_ref() would return a status
code instead of die():ing if it can't parse the given sha1.  In a
future libification, the change of return type may have to be
reverted.

  nikolai