git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 28/28] makes upload_pack void

From
DRDavid Rientjes <rientjes@google.com>
Date
Aug 14, 2006, 20:40 UTC
Message-ID
<Pine.LNX.4.63.0608141340060.19383@chino.corp.google.com>
Makes upload_pack void and removes conditional return.
		David
Signed-off-by: David Rientjes <rientjes@google.com>
---
 upload-pack.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/upload-pack.c b/upload-pack.c
index bbd6bd6..27e2abe 100644
--- a/upload-pack.c
+++ b/upload-pack.c
@@ -459,18 +459,17 @@ static int send_ref(const char *refname,
 	return 0;
 }
 
-static int upload_pack(void)
+static void upload_pack(void)
 {
 	reset_timeout();
 	head_ref(send_ref);
 	for_each_ref(send_ref);
 	packet_flush(1);
 	receive_needs();
-	if (!want_obj.nr)
-		return 0;
-	get_common_commits();
-	create_pack_file();
-	return 0;
+	if (want_obj.nr) {
+		get_common_commits();
+		create_pack_file();
+	}
 }
 
 int main(int argc, char **argv)
-- 
1.4.2.g89bb-dirty
Next: Nikolai Weibull
Message 1 of 4 in “makes upload_pack void”
  1. 28/28 makes upload_pack voidDavid Rientjes, Aug 14, 2006
  2. Nikolai WeibullAug 14, 2006
  3. David RientjesAug 14, 2006
  4. Nikolai WeibullAug 14, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.