Re: [PATCH 28/28] makes upload_pack void

From: Nikolai Weibull <now@bitwi.se>
Date: Aug 14, 2006, 23:03 UTC
Message-ID: <dbfc82860608141603y64737257n85cc169a6f58ff7e@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.63.0608141549150.21515@chino.corp.google.com>

On 8/15/06, David Rientjes <rientjes@google.com> wrote:

Show 7 quoted lines

> On Tue, 15 Aug 2006, Nikolai Weibull wrote:
> > I don't know for sure, but I'm guessing the intention was to be able
> > to return a failing code /if/ there ever was a condition where
> > upload_pack() would fail, e.g., if send_ref() would return a status
> > code instead of die():ing if it can't parse the given sha1.  In a
> > future libification, the change of return type may have to be
> > reverted.

> Of course.
>
> If upload_pack were modified to return an error code based on a specific code
> path, I trust the implementer would know how to change void to int.

So do I. However, I trust that whoever implemented send_ref() knew about void. (See how easy it was to do what you did but the other way around?)

It was just a comment.  I don't have anything against the patch as such.

  nikolai