git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] compat/mingw.c: MSVC build must use ANSI Win32 API's

From
Michael Wookey <michaelwookey@gmail.com>
Date
Sep 28, 2009, 07:47 UTC
Message-ID
<d2e97e800909280047l5da52ffdxd86589cda4542f46@mail.gmail.com>
In-Reply-To
<4AC05BA5.4050106@viscovery.net>
2009/9/28 Johannes Sixt <j.sixt@viscovery.net>:
Show 19 quoted lines
> Michael Wookey schrieb:
>> 2009/9/22 Marius Storm-Olsen <mstormo@gmail.com>:
>>> Michael Wookey said the following on 22.09.2009 11:17:
>>>> 2009/9/22 Marius Storm-Olsen <mstormo@gmail.com>:
>>>>> Michael, how are you trying to compile git? With the IDE or the
>>>>> GNU Make? Which version of MSVC? If you use the IDE, can you make
>>>>> sure it doesn't contain the UNICODE define in the compiler
>>>>> section of the properties of the projects?
>>>> I'm using the VS 2008 Professional IDE (the solution doesn't open
>>>> in VS 2005). I made no changes to the build settings. In the
>>>> Preprocessor section of the project, UNICODE is defined.
>>> Were these projects generated with the Vcproj generator in
>>> contrib/buildsystem, with the Qmake generator, or the projects from Frank's
>>> repo?
>>
>> The project was generated from the vcproj generator in
>> contrib/buildsystem from git.git/master.
>
> What's the status of this?

I was hoping that this gets included into git.git because it fixes a real issue with MSVC builds. Since Junio is away, perhaps Shawn can take the patch into his interim tree?

BTW - would you mind giving this patch an ack?
Show 5 quoted lines
> Do Sebastian Schuberth's patches
> http://article.gmane.org/gmane.comp.version-control.msysgit/7152
> http://article.gmane.org/gmane.comp.version-control.msysgit/7153
>
> make a difference?
Unfortunately, no. Those patches do not make a difference.
Previous: Johannes SixtNext: Johannes Sixt
Message 9 of 13 in “compat/mingw.c: MSVC build must use ANSI Win32 API's”
  1. compat/mingw.c: MSVC build must use ANSI Win32 API'sMichael Wookey, Sep 22, 2009
  2. Johannes SixtSep 22, 2009
  3. Marius Storm-OlsenSep 22, 2009
  4. Michael WookeySep 22, 2009
  5. Marius Storm-OlsenSep 22, 2009
  6. Michael WookeySep 22, 2009
  7. Michael WookeySep 23, 2009
  8. Johannes SixtSep 28, 2009
  9. Michael WookeySep 28, 2009
  10. Johannes SixtSep 28, 2009
  11. Michael WookeySep 28, 2009
  12. Michael WookeySep 28, 2009
  13. Marius Storm-OlsenSep 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.