From: Michael Wookey Date: Mon, 28 Sep 2009 07:47:08 GMT Subject: Re: [PATCH] compat/mingw.c: MSVC build must use ANSI Win32 API's Message-ID: In-Reply-To: <4AC05BA5.4050106@viscovery.net> 2009/9/28 Johannes Sixt : > Michael Wookey schrieb: >> 2009/9/22 Marius Storm-Olsen : >>> Michael Wookey said the following on 22.09.2009 11:17: >>>> 2009/9/22 Marius Storm-Olsen : >>>>> Michael, how are you trying to compile git? With the IDE or the >>>>> GNU Make? Which version of MSVC? If you use the IDE, can you make >>>>> sure it doesn't contain the UNICODE define in the compiler >>>>> section of the properties of the projects? >>>> I'm using the VS 2008 Professional IDE (the solution doesn't open >>>> in VS 2005). I made no changes to the build settings. In the >>>> Preprocessor section of the project, UNICODE is defined. >>> Were these projects generated with the Vcproj generator in >>> contrib/buildsystem, with the Qmake generator, or the projects from Frank's >>> repo? >> >> The project was generated from the vcproj generator in >> contrib/buildsystem from git.git/master. > > What's the status of this? I was hoping that this gets included into git.git because it fixes a real issue with MSVC builds. Since Junio is away, perhaps Shawn can take the patch into his interim tree? BTW - would you mind giving this patch an ack? > Do Sebastian Schuberth's patches > http://article.gmane.org/gmane.comp.version-control.msysgit/7152 > http://article.gmane.org/gmane.comp.version-control.msysgit/7153 > > make a difference? Unfortunately, no. Those patches do not make a difference.