git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] compat/mingw.c: MSVC build must use ANSI Win32 API's

From
Marius Storm-Olsen <mstormo@gmail.com>
Date
Sep 28, 2009, 10:21 UTC
Message-ID
<4AC08E45.8010707@gmail.com>
In-Reply-To
<d2e97e800909280255h70e4c006m98cde895b95fef29@mail.gmail.com>
Michael Wookey said the following on 28.09.2009 11:55:
Show 11 quoted lines
>> It seems that the project file that is generated by Vcproj.pm
>> (inadvertently?) defines UNICODE. Perhaps the patch below is better
>> than my original workaround. If you think so, I'll create a formal
>> patch.
>>
>> [ sorry if the patch wraps ]
>>
> 
> scrub the previous patch... there were more instances of UNICODE
> defined (for release and debug builds). The patch below takes care of
> them all.

Yup, IMO this is the correct patch, since it will follow the Makefile more closely. So, if we then decide to add UNICODE in the Makefile, the generated files will follow.

Make it into a proper patch, and I'll ack.

-- .marius

Previous: Michael Wookey
Message 13 of 13 in “compat/mingw.c: MSVC build must use ANSI Win32 API's”
  1. compat/mingw.c: MSVC build must use ANSI Win32 API'sMichael Wookey, Sep 22, 2009
  2. Johannes SixtSep 22, 2009
  3. Marius Storm-OlsenSep 22, 2009
  4. Michael WookeySep 22, 2009
  5. Marius Storm-OlsenSep 22, 2009
  6. Michael WookeySep 22, 2009
  7. Michael WookeySep 23, 2009
  8. Johannes SixtSep 28, 2009
  9. Michael WookeySep 28, 2009
  10. Johannes SixtSep 28, 2009
  11. Michael WookeySep 28, 2009
  12. Michael WookeySep 28, 2009
  13. Marius Storm-OlsenSep 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.