git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] compat/mingw.c: MSVC build must use ANSI Win32 API's

From
Michael Wookey <michaelwookey@gmail.com>
Date
Sep 23, 2009, 04:43 UTC
Message-ID
<d2e97e800909222143y2cb3b37bq7f6d018c06934ab8@mail.gmail.com>
In-Reply-To
<d2e97e800909220254sc677abeia220c19f6ef5bd28@mail.gmail.com>
2009/9/22 Michael Wookey <michaelwookey@gmail.com>:
Show 15 quoted lines
> 2009/9/22 Marius Storm-Olsen <mstormo@gmail.com>:
>>> On another note, I see *many* build warnings for things like
>>> "signed/unsigned compares". I'd be willing to work through these warnings
>>> and fix them. Thoughts?
>>
>> Well, first find out why these are a problem with MSVC and not GCC. Are the
>> types different on these platforms? signed vs unsigned should show up with
>> GCC as well. We need to make sure that we don't fix signed/unsigned issues
>> on one platform, just to introduce it to another platform.
>> In any case, it would be good for someone to have a look at these, just so
>> we can determine the cause for most of them, and then we should figure out
>> on the list how to deal with them.
>
> Well, at warning level 4, MSVC is quite verbose. Perhaps the current
> gcc build flags are more forgiving?
Ah, gcc does produces similar warnings when "-Wextra" is added to the CFLAGS:
  CFLAGS = -g -O2 -Wall -Wextra

IMHO, warnings such as these should be worked through and fixed, or there may be some latent bug waiting to appear.

Previous: Michael WookeyNext: Johannes Sixt
Message 7 of 13 in “compat/mingw.c: MSVC build must use ANSI Win32 API's”
  1. compat/mingw.c: MSVC build must use ANSI Win32 API'sMichael Wookey, Sep 22, 2009
  2. Johannes SixtSep 22, 2009
  3. Marius Storm-OlsenSep 22, 2009
  4. Michael WookeySep 22, 2009
  5. Marius Storm-OlsenSep 22, 2009
  6. Michael WookeySep 22, 2009
  7. Michael WookeySep 23, 2009
  8. Johannes SixtSep 28, 2009
  9. Michael WookeySep 28, 2009
  10. Johannes SixtSep 28, 2009
  11. Michael WookeySep 28, 2009
  12. Michael WookeySep 28, 2009
  13. Marius Storm-OlsenSep 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.