From: Michael Wookey Date: Wed, 23 Sep 2009 04:43:31 GMT Subject: Re: [PATCH] compat/mingw.c: MSVC build must use ANSI Win32 API's Message-ID: In-Reply-To: 2009/9/22 Michael Wookey : > 2009/9/22 Marius Storm-Olsen : >>> On another note, I see *many* build warnings for things like >>> "signed/unsigned compares". I'd be willing to work through these warnings >>> and fix them. Thoughts? >> >> Well, first find out why these are a problem with MSVC and not GCC. Are the >> types different on these platforms? signed vs unsigned should show up with >> GCC as well. We need to make sure that we don't fix signed/unsigned issues >> on one platform, just to introduce it to another platform. >> In any case, it would be good for someone to have a look at these, just so >> we can determine the cause for most of them, and then we should figure out >> on the list how to deal with them. > > Well, at warning level 4, MSVC is quite verbose. Perhaps the current > gcc build flags are more forgiving? Ah, gcc does produces similar warnings when "-Wextra" is added to the CFLAGS: CFLAGS = -g -O2 -Wall -Wextra IMHO, warnings such as these should be worked through and fixed, or there may be some latent bug waiting to appear.