git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 4/7] Fix tests under GETTEXT_POISON on git-apply

From
Jiang Xin <worldhello.net@gmail.com>
Date
Aug 27, 2012, 05:36 UTC
Message-ID
<d20c47e9618f998b84934c0310f3de51d791e83f.1346045253.git.worldhello.net@gmail.com>
In-Reply-To
<7398781c6d647557954f4a0c7df29fc98aad842b.1346045253.git.worldhello.net@gmail.com>

Use i18n-specific test functions in test scripts for git-apply. This issue was was introduced in the following commits:

    de373 i18n: apply: mark parseopt strings for translation
    3638e i18n: apply: mark strings for translation
and been broken under GETTEXT_POISON=YesPlease since.
Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 t/t4012-diff-binary.sh     | 4 ++--
 t/t4120-apply-popt.sh      | 4 ++--
 t/t4133-apply-filenames.sh | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh
index ec4de..1215a 100755
--- a/t/t4012-diff-binary.sh
+++ b/t/t4012-diff-binary.sh
@@ -63,7 +63,7 @@ test_expect_success 'apply --numstat understands diff --binary format' '
 
 # apply needs to be able to skip the binary material correctly
 # in order to report the line number of a corrupt patch.
-test_expect_success 'apply detecting corrupt patch correctly' '
+test_expect_success C_LOCALE_OUTPUT 'apply detecting corrupt patch correctly' '
 	git diff >output &&
 	sed -e "s/-CIT/xCIT/" <output >broken &&
 	test_must_fail git apply --stat --summary broken 2>detected &&
@@ -73,7 +73,7 @@ test_expect_success 'apply detecting corrupt patch correctly' '
 	test "$detected" = xCIT
 '
 
-test_expect_success 'apply detecting corrupt patch correctly' '
+test_expect_success C_LOCALE_OUTPUT 'apply detecting corrupt patch correctly' '
 	git diff --binary | sed -e "s/-CIT/xCIT/" >broken &&
 	test_must_fail git apply --stat --summary broken 2>detected &&
 	detected=`cat detected` &&
diff --git a/t/t4120-apply-popt.sh b/t/t4120-apply-popt.sh
index a33d5..c5fec 100755
--- a/t/t4120-apply-popt.sh
+++ b/t/t4120-apply-popt.sh
@@ -32,7 +32,7 @@ test_expect_success 'apply git diff with -p2' '
 test_expect_success 'apply with too large -p' '
 	cp file1.saved file1 &&
 	test_must_fail git apply --stat -p3 patch.file 2>err &&
-	grep "removing 3 leading" err
+	test_i18ngrep "removing 3 leading" err
 '
 
 test_expect_success 'apply (-p2) traditional diff with funny filenames' '
@@ -54,7 +54,7 @@ test_expect_success 'apply (-p2) traditional diff with funny filenames' '
 test_expect_success 'apply with too large -p and fancy filename' '
 	cp file1.saved file1 &&
 	test_must_fail git apply --stat -p3 patch.escaped 2>err &&
-	grep "removing 3 leading" err
+	test_i18ngrep "removing 3 leading" err
 '
 
 test_expect_success 'apply (-p2) diff, mode change only' '
diff --git a/t/t4133-apply-filenames.sh b/t/t4133-apply-filenames.sh
index 94da9..2ecb4 100755
--- a/t/t4133-apply-filenames.sh
+++ b/t/t4133-apply-filenames.sh
@@ -30,9 +30,9 @@ EOF
 
 test_expect_success 'apply diff with inconsistent filenames in headers' '
 	test_must_fail git apply bad1.patch 2>err &&
-	grep "inconsistent new filename" err &&
+	test_i18ngrep "inconsistent new filename" err &&
 	test_must_fail git apply bad2.patch 2>err &&
-	grep "inconsistent old filename" err
+	test_i18ngrep "inconsistent old filename" err
 '
 
 test_done
-- 
1.7.12.92.gaa91cb5
Previous: Jiang XinNext: Jiang Xin
Message 20 of 27 in “Gettext poison fixes”
  1. 0/7 Gettext poison fixesNguyễn Thái Ngọc Duy, Aug 21, 2012
  2. 1/7 Fix tests under GETTEXT_POISON on relative datesNguyễn Thái Ngọc Duy, Aug 21, 2012
  3. 2/7 Fix tests under GETTEXT_POISON on git-stashNguyễn Thái Ngọc Duy, Aug 21, 2012
  4. 3/7 Fix tests under GETTEXT_POISON on diffstatNguyễn Thái Ngọc Duy, Aug 21, 2012
  5. 4/7 Fix tests under GETTEXT_POISON on git-applyNguyễn Thái Ngọc Duy, Aug 21, 2012
  6. 5/7 Fix tests under GETTEXT_POISON on pack-objectNguyễn Thái Ngọc Duy, Aug 21, 2012
  7. Jonathan NiederAug 21, 2012
  8. Nguyen Thai Ngoc DuyAug 21, 2012
  9. Jonathan NiederAug 21, 2012
  10. Junio C HamanoAug 21, 2012
  11. 6/7 Fix tests under GETTEXT_POISON on git-remoteNguyễn Thái Ngọc Duy, Aug 21, 2012
  12. Junio C HamanoAug 21, 2012
  13. Jiang XinAug 22, 2012
  14. Junio C HamanoAug 22, 2012
  15. 7/7 Fix tests under GETTEXT_POISON on parseoptNguyễn Thái Ngọc Duy, Aug 21, 2012
  16. 0/7 Gettext poison fixesJiang Xin, Aug 27, 2012
  17. 1/7 Fix tests under GETTEXT_POISON on relative datesJiang Xin, Aug 27, 2012
  18. 2/7 Fix tests under GETTEXT_POISON on git-stashJiang Xin, Aug 27, 2012
  19. 3/7 Fix tests under GETTEXT_POISON on diffstatJiang Xin, Aug 27, 2012
  20. 4/7 Fix tests under GETTEXT_POISON on git-applyJiang Xin, Aug 27, 2012
  21. 5/7 Fix tests under GETTEXT_POISON on pack-objectJiang Xin, Aug 27, 2012
  22. 6/7 Fix tests under GETTEXT_POISON on git-remoteJiang Xin, Aug 27, 2012
  23. 7/7 Fix tests under GETTEXT_POISON on parseoptJiang Xin, Aug 27, 2012
  24. Junio C HamanoAug 27, 2012
  25. Jiang XinAug 27, 2012
  26. Junio C HamanoAug 28, 2012
  27. Junio C HamanoAug 27, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.