git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/7] Fix tests under GETTEXT_POISON on git-remote

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Aug 21, 2012, 04:31 UTC
Message-ID
<1345523464-14586-7-git-send-email-pclouds@gmail.com>
In-Reply-To
<1345523464-14586-1-git-send-email-pclouds@gmail.com>
From: Jiang Xin <worldhello.net@gmail.com>

Use i18n-specific test functions in test scripts for git-remote. This issue was was introduced in v1.7.10-233-gbb16d5:

    bb16d5 i18n: remote: mark strings for translation
and been broken under GETTEXT_POISON=YesPlease since.
Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 t/t5505-remote.sh | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
index e8af615..07045e3 100755
--- a/t/t5505-remote.sh
+++ b/t/t5505-remote.sh
@@ -27,10 +27,16 @@ tokens_match () {
 	test_cmp expect actual
 }
 
+tokens_i18nmatch () {
+	echo "$1" | tr ' ' '\012' | sort | sed -e '/^$/d' >expect &&
+	echo "$2" | tr ' ' '\012' | sort | sed -e '/^$/d' >actual &&
+	test_i18ncmp expect actual
+}
+
 check_remote_track () {
 	actual=$(git remote show "$1" | sed -ne 's|^    \(.*\) tracked$|\1|p')
 	shift &&
-	tokens_match "$*" "$actual"
+	tokens_i18nmatch "$*" "$actual"
 }
 
 check_tracking_branch () {
@@ -131,8 +137,8 @@ EOF
 	git remote rm oops 2>actual2 &&
 	git branch -d foobranch &&
 	git tag -d footag &&
-	test_cmp expect1 actual1 &&
-	test_cmp expect2 actual2
+	test_i18ncmp expect1 actual1 &&
+	test_i18ncmp expect2 actual2
 )
 '
 
@@ -192,7 +198,7 @@ test_expect_success 'show' '
 	 git config --add remote.two.push refs/heads/master:refs/heads/another &&
 	 git remote show origin two > output &&
 	 git branch -d rebase octopus &&
-	 test_cmp expect output)
+	 test_i18ncmp expect output)
 '
 
 cat > test/expect << EOF
@@ -217,7 +223,7 @@ test_expect_success 'show -n' '
 	 cd test &&
 	 git remote show -n origin > output &&
 	 mv ../one.unreachable ../one &&
-	 test_cmp expect output)
+	 test_i18ncmp expect output)
 '
 
 test_expect_success 'prune' '
@@ -255,7 +261,7 @@ EOF
 test_expect_success 'set-head --auto fails w/multiple HEADs' '
 	(cd test &&
 	 test_must_fail git remote set-head --auto two >output 2>&1 &&
-	test_cmp expect output)
+	test_i18ncmp expect output)
 '
 
 cat >test/expect <<EOF
@@ -285,7 +291,7 @@ test_expect_success 'prune --dry-run' '
 	 test_must_fail git rev-parse refs/remotes/origin/side &&
 	(cd ../one &&
 	 git branch -m side side2) &&
-	 test_cmp expect output)
+	 test_i18ncmp expect output)
 '
 
 test_expect_success 'add --mirror && prune' '
@@ -705,7 +711,7 @@ test_expect_success 'remote prune to cause a dangling symref' '
 		cd seven &&
 		git remote prune origin
 	) >err 2>&1 &&
-	grep "has become dangling" err &&
+	test_i18ngrep "has become dangling" err &&
 
 	: And the dangling symref will not cause other annoying errors &&
 	(
-- 
1.7.12.rc2
Previous: Junio C HamanoNext: Junio C Hamano
Message 11 of 27 in “Gettext poison fixes”
  1. 0/7 Gettext poison fixesNguyễn Thái Ngọc Duy, Aug 21, 2012
  2. 1/7 Fix tests under GETTEXT_POISON on relative datesNguyễn Thái Ngọc Duy, Aug 21, 2012
  3. 2/7 Fix tests under GETTEXT_POISON on git-stashNguyễn Thái Ngọc Duy, Aug 21, 2012
  4. 3/7 Fix tests under GETTEXT_POISON on diffstatNguyễn Thái Ngọc Duy, Aug 21, 2012
  5. 4/7 Fix tests under GETTEXT_POISON on git-applyNguyễn Thái Ngọc Duy, Aug 21, 2012
  6. 5/7 Fix tests under GETTEXT_POISON on pack-objectNguyễn Thái Ngọc Duy, Aug 21, 2012
  7. Jonathan NiederAug 21, 2012
  8. Nguyen Thai Ngoc DuyAug 21, 2012
  9. Jonathan NiederAug 21, 2012
  10. Junio C HamanoAug 21, 2012
  11. 6/7 Fix tests under GETTEXT_POISON on git-remoteNguyễn Thái Ngọc Duy, Aug 21, 2012
  12. Junio C HamanoAug 21, 2012
  13. Jiang XinAug 22, 2012
  14. Junio C HamanoAug 22, 2012
  15. 7/7 Fix tests under GETTEXT_POISON on parseoptNguyễn Thái Ngọc Duy, Aug 21, 2012
  16. 0/7 Gettext poison fixesJiang Xin, Aug 27, 2012
  17. 1/7 Fix tests under GETTEXT_POISON on relative datesJiang Xin, Aug 27, 2012
  18. 2/7 Fix tests under GETTEXT_POISON on git-stashJiang Xin, Aug 27, 2012
  19. 3/7 Fix tests under GETTEXT_POISON on diffstatJiang Xin, Aug 27, 2012
  20. 4/7 Fix tests under GETTEXT_POISON on git-applyJiang Xin, Aug 27, 2012
  21. 5/7 Fix tests under GETTEXT_POISON on pack-objectJiang Xin, Aug 27, 2012
  22. 6/7 Fix tests under GETTEXT_POISON on git-remoteJiang Xin, Aug 27, 2012
  23. 7/7 Fix tests under GETTEXT_POISON on parseoptJiang Xin, Aug 27, 2012
  24. Junio C HamanoAug 27, 2012
  25. Jiang XinAug 27, 2012
  26. Junio C HamanoAug 28, 2012
  27. Junio C HamanoAug 27, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.