Re: [PATCH v2 6/7] Fix tests under GETTEXT_POISON on git-remote

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 27, 2012, 16:28 UTC
Message-ID: <7v4nnoti3l.fsf@alter.siamese.dyndns.org>
In-Reply-To: <f56c058cfd76d02ed42b0c5b7161bde6bd51ddd0.1346045253.git.worldhello.net@gmail.com>

Jiang Xin <worldhello.net@gmail.com> writes:

Show 22 quoted lines

> Use i18n-specific test functions in test scripts for git-remote.
> This issue was was introduced in v1.7.10-233-gbb16d5:
>
>     bb16d5 i18n: remote: mark strings for translation
>
> and been broken under GETTEXT_POISON=YesPlease since.
>
> Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> ...
> @@ -77,6 +75,14 @@ test_expect_success 'add another remote' '
>  )
>  '
>  
> +test_expect_success C_LOCALE_OUTPUT 'add another remote' '
> +(
> +	cd test &&
> +	check_remote_track origin master side &&
> +	check_remote_track second master side another &&
> +)
> +'

This couldn't have possibly passed with the trailing &&, or am I missing something? There is already "add another remote" before this test that adds "second" remote. Is this test about "add yet another remote", or is it checking the result of adding "second" that was done in the previous step?

Will queue with an obvious fix-up with retitle, 'check tracking', or something.

Thanks.