git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/7] Fix tests under GETTEXT_POISON on pack-object

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Aug 21, 2012, 04:31 UTC
Message-ID
<1345523464-14586-6-git-send-email-pclouds@gmail.com>
In-Reply-To
<1345523464-14586-1-git-send-email-pclouds@gmail.com>
From: Jiang Xin <worldhello.net@gmail.com>

Use i18n-specific test functions in test scripts for pack-object. This issue was was introduced in v1.7.10.2-556-g46140:

    46140 index-pack: use streaming interface for collision test on large blobs
    cf2ba pack-objects: use streaming interface for reading large loose blobs
and been broken under GETTEXT_POISON=YesPlease since.
Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 t/t5300-pack-object.sh       | 4 ++--
 t/t5530-upload-pack-error.sh | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh
index 2e52f8b..a07c871 100755
--- a/t/t5300-pack-object.sh
+++ b/t/t5300-pack-object.sh
@@ -416,11 +416,11 @@ test_expect_success \
 test_expect_success \
     'make sure index-pack detects the SHA1 collision' \
     'test_must_fail git index-pack -o bad.idx test-3.pack 2>msg &&
-     grep "SHA1 COLLISION FOUND" msg'
+     test_i18ngrep "SHA1 COLLISION FOUND" msg'
 
 test_expect_success \
     'make sure index-pack detects the SHA1 collision (large blobs)' \
     'test_must_fail git -c core.bigfilethreshold=1 index-pack -o bad.idx test-3.pack 2>msg &&
-     grep "SHA1 COLLISION FOUND" msg'
+     test_i18ngrep "SHA1 COLLISION FOUND" msg'
 
 test_done
diff --git a/t/t5530-upload-pack-error.sh b/t/t5530-upload-pack-error.sh
index 6b2a5f4..99f8dbc 100755
--- a/t/t5530-upload-pack-error.sh
+++ b/t/t5530-upload-pack-error.sh
@@ -35,7 +35,7 @@ test_expect_success 'upload-pack fails due to error in pack-objects packing' '
 	printf "0032want %s\n00000009done\n0000" \
 		$(git rev-parse HEAD) >input &&
 	test_must_fail git upload-pack . <input >/dev/null 2>output.err &&
-	grep "unable to read" output.err &&
+	test_i18ngrep "unable to read" output.err &&
 	grep "pack-objects died" output.err
 '
 
-- 
1.7.12.rc2
Previous: Nguyễn Thái Ngọc DuyNext: Jonathan Nieder
Message 6 of 27 in “Gettext poison fixes”
  1. 0/7 Gettext poison fixesNguyễn Thái Ngọc Duy, Aug 21, 2012
  2. 1/7 Fix tests under GETTEXT_POISON on relative datesNguyễn Thái Ngọc Duy, Aug 21, 2012
  3. 2/7 Fix tests under GETTEXT_POISON on git-stashNguyễn Thái Ngọc Duy, Aug 21, 2012
  4. 3/7 Fix tests under GETTEXT_POISON on diffstatNguyễn Thái Ngọc Duy, Aug 21, 2012
  5. 4/7 Fix tests under GETTEXT_POISON on git-applyNguyễn Thái Ngọc Duy, Aug 21, 2012
  6. 5/7 Fix tests under GETTEXT_POISON on pack-objectNguyễn Thái Ngọc Duy, Aug 21, 2012
  7. Jonathan NiederAug 21, 2012
  8. Nguyen Thai Ngoc DuyAug 21, 2012
  9. Jonathan NiederAug 21, 2012
  10. Junio C HamanoAug 21, 2012
  11. 6/7 Fix tests under GETTEXT_POISON on git-remoteNguyễn Thái Ngọc Duy, Aug 21, 2012
  12. Junio C HamanoAug 21, 2012
  13. Jiang XinAug 22, 2012
  14. Junio C HamanoAug 22, 2012
  15. 7/7 Fix tests under GETTEXT_POISON on parseoptNguyễn Thái Ngọc Duy, Aug 21, 2012
  16. 0/7 Gettext poison fixesJiang Xin, Aug 27, 2012
  17. 1/7 Fix tests under GETTEXT_POISON on relative datesJiang Xin, Aug 27, 2012
  18. 2/7 Fix tests under GETTEXT_POISON on git-stashJiang Xin, Aug 27, 2012
  19. 3/7 Fix tests under GETTEXT_POISON on diffstatJiang Xin, Aug 27, 2012
  20. 4/7 Fix tests under GETTEXT_POISON on git-applyJiang Xin, Aug 27, 2012
  21. 5/7 Fix tests under GETTEXT_POISON on pack-objectJiang Xin, Aug 27, 2012
  22. 6/7 Fix tests under GETTEXT_POISON on git-remoteJiang Xin, Aug 27, 2012
  23. 7/7 Fix tests under GETTEXT_POISON on parseoptJiang Xin, Aug 27, 2012
  24. Junio C HamanoAug 27, 2012
  25. Jiang XinAug 27, 2012
  26. Junio C HamanoAug 28, 2012
  27. Junio C HamanoAug 27, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.