Re: [PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio)

From: Torsten Bögershausen <tboegi@web.de>
Date: Apr 10, 2019, 05:32 UTC
Message-ID: <d1cf10ec-ca57-09e3-cf00-3be87dec06ee@web.de>
In-Reply-To: <xmqqv9zn2kjs.fsf@gitster-ct.c.googlers.com>

On 2019-04-09 18:46, Junio C Hamano wrote:

Show 16 quoted lines

> Torsten Bögershausen <tboegi@web.de> writes:
>
>>> 1cadad6f6 removes mingw_offset_1st_component from mingw.c which is
>>> included by msvc.c. Then the in git-compat.h the new file
>>> "compat/win32/path-utils.h" is only included for __CYGWIN__ and
>>> __MINGW32__, here _MSC_VER is missing -> that's the regression.
>>>
>>
>> OK, good.
>> If possible, I would like to see this kind of information
>> in the commit message.
>> Thanks for cleaning up my mess.
>
> Thanks, both.  Should I wait for an update that fixes the proposed
> log message?
>

It seems that I haven't read all messages in my mailbox (or messages crossed).

The V2 patch describes the problem well and looks OK for me.