git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio)

From
Sven Strickroth <email@cs-ware.de>
Date
Apr 8, 2019, 11:16 UTC
Message-ID
<6c7d4155-e554-dc9a-053e-f3a8c7cd4075@cs-ware.de>

A path such as 'c:/somepath/submodule/../.git/modules/submodule' wasn't resolved correctly any more, because the *nix variant of offset_1st_component is used instead of the Win32 specific version.

Regression was introduced in commit 25d90d1cb72ce51407324259516843406142fe89.

Signed-off-by: Sven Strickroth <email@cs-ware.de>
---
 git-compat-util.h | 1 +
 1 file changed, 1 insertion(+)
diff --git a/git-compat-util.h b/git-compat-util.h
index e0275da7e0..9be177e588 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -210,6 +210,7 @@
 #include "compat/mingw.h"
 #include "compat/win32/fscache.h"
 #elif defined(_MSC_VER)
+#include "compat/win32/path-utils.h"
 #include "compat/msvc.h"
 #include "compat/win32/fscache.h"
 #else
-- 
2.21.0.windows.1
Next: Taylor Blau
Message 1 of 10 in “Unbreak real_path on Windows for already absolute paths (with Visual Studio)”
  1. Unbreak real_path on Windows for already absolute paths (with Visual Studio)Sven Strickroth, Apr 8, 2019
  2. Taylor BlauApr 9, 2019
  3. Torsten BögershausenApr 9, 2019
  4. Sven StrickrothApr 9, 2019
  5. MSVC: Unbreak real_path for Windows pathsSven Strickroth, Apr 8, 2019
  6. Junio C HamanoApr 9, 2019
  7. Torsten BögershausenApr 9, 2019
  8. Junio C HamanoApr 9, 2019
  9. Torsten BögershausenApr 10, 2019
  10. Junio C HamanoApr 12, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.