Re: [PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio)
- From
- Sven Strickroth <sven@cs-ware.de>
- Date
- Apr 9, 2019, 07:34 UTC
- Message-ID
- <950ee9b8-786f-28cd-3e89-ad174fd857a4@cs-ware.de>
- In-Reply-To
- <0f629384-638f-bfb9-89da-ade335e364fd@web.de>
Am 09.04.2019 um 07:53 schrieb Torsten Bögershausen:
Show 6 quoted lines
>> Regression was introduced in commit >> 25d90d1cb72ce51407324259516843406142fe89. > > Was it ? > 25d90d1cb merged this commit: > 1cadad6f6 (junio/tb/use-common-win32-pathfuncs-on-cygwin)
Yes, I copied the revision of the merge commit.
> And, if I read that correctly, 1cadad6f6 does not change anything for MSVC. > And the problem with the missing/wrong path resolution was there before > 1cadad6f6 and after 1cadad6f6.
That's not correct, it was correct before: 1cadad6f6 removes mingw_offset_1st_component from mingw.c which is included by msvc.c. Then the in git-compat.h the new file "compat/win32/path-utils.h" is only included for __CYGWIN__ and __MINGW32__, here _MSC_VER is missing -> that's the regression.
Show 5 quoted lines
> In config.mak.uname we need to add a line > compat/win32/path-utils.o > for the Windows build. > In the git-for windows codebase I see > COMPAT_OBJS +=compat/win32/path-utils
I don't use config.mak.uname and never did, so I can't tell you about that.
-- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server