Re: [PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio)
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- Apr 9, 2019, 16:19 UTC
- Message-ID
- <af640e82-ca1a-9c96-da47-62aaea1cc18e@web.de>
- In-Reply-To
- <950ee9b8-786f-28cd-3e89-ad174fd857a4@cs-ware.de>
On 2019-04-09 09:34, Sven Strickroth wrote:
Show 15 quoted lines
> Am 09.04.2019 um 07:53 schrieb Torsten Bögershausen: >>> Regression was introduced in commit >>> 25d90d1cb72ce51407324259516843406142fe89. >> >> Was it ? >> 25d90d1cb merged this commit: >> 1cadad6f6 (junio/tb/use-common-win32-pathfuncs-on-cygwin) > > Yes, I copied the revision of the merge commit. > >> And, if I read that correctly, 1cadad6f6 does not change anything for MSVC. >> And the problem with the missing/wrong path resolution was there before >> 1cadad6f6 and after 1cadad6f6. > > That's not correct, it was correct before:
No, I wasn't aware that msvc.c include mingw.c - for whatever reason.
Show 5 quoted lines
> 1cadad6f6 removes mingw_offset_1st_component from mingw.c which is > included by msvc.c. Then the in git-compat.h the new file > "compat/win32/path-utils.h" is only included for __CYGWIN__ and > __MINGW32__, here _MSC_VER is missing -> that's the regression. >
OK, good. If possible, I would like to see this kind of information in the commit message. Thanks for cleaning up my mess.