Re: What's cooking in git.git (Jun 2021, #07; Wed, 30)

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Jul 6, 2021, 13:46 UTC
Message-ID: <d04c71fe-acfb-abe0-b00f-cfa01651dd57@gmail.com>
In-Reply-To: <CABPp-BGF4K4mAXf6X1rTpTmPCfQgwdhv_VUVg2icGk5Dw7Q1yw@mail.gmail.com>

On 03/07/2021 06:04, Elijah Newren wrote:

Show 23 quoted lines

> On Wed, Jun 30, 2021 at 3:58 PM Junio C Hamano <gitster@pobox.com> wrote:
>> * pw/diff-color-moved-fix (2021-06-15) 10 commits
>>   - diff --color-moved: intern strings
>>   - diff --color-moved-ws=allow-indentation-change: improve hash lookups
>>   - diff --color-moved: stop clearing potential moved blocks
>>   - diff --color-moved: shrink potential moved blocks as we go
>>   - diff --color-moved: unify moved block growth functions
>>   - diff --color-moved: call comparison function directly
>>   - diff --color-moved-ws=allow-indentation-change: simplify and optimize
>>   - diff: simplify allow-indentation-change delta calculation
>>   - diff --color-moved: avoid false short line matches and bad zebra coloring
>>   - diff --color-moved=zebra: fix alternate coloring
>>
>>   Long-overdue correctness and performance update to "diff
>>   --color-moved" feature.
>>
>>   Waiting for reviews.
> 
> I read through the first half the patches or so and didn't spot
> anything wrong, though I'm very unfamiliar with this code area and
> don't yet understand much of what's going on; it was more of a spot
> check.  I'll try to get back to it again, but my review probably won't
> be that deep.

Thanks for taking a look, do let me know if I can do anything to make reviewing this series easier

Best Wishes

Phillip