Re: What's cooking in git.git (Jun 2021, #07; Wed, 30)

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jul 1, 2021, 13:06 UTC
Message-ID: <87zgv6cgxs.fsf@evledraar.gmail.com>
In-Reply-To: <CAFQ2z_Opw4dZmH7Xc4tRzMvD-op-Reh3C7sM31VoNM5eAHaiLA@mail.gmail.com>

On Thu, Jul 01 2021, Han-Wen Nienhuys wrote:

Show 12 quoted lines

> (now in plain text)
>
> On Thu, Jul 1, 2021 at 9:17 AM Han-Wen Nienhuys <hanwen@google.com> wrote:
>>>  Futz with the way 'errno' is relied on in the refs API to carry the
>>>  failure modes up the callchain.
>>>
>>>  Will merge to 'next'?
>
> Is there anything I can do to address the '?' here?
>
> I am happy to do a review for a similar sized chunk of other code for
> someone else in exchange for review of this.

I took you up on that and gave that series a detailed look now[1].

I'm afraid what I had to say there doesn't bode well for getting it to 'next' (some style/questions etc. there, but also what I believe is a serious bug in 8/8 was among the findings[2]).

I'd like you to take a look & review any of my outstanding "ab/*" serieses (or combinatino thereof) of similar scope/complexity as yours in return. I'l leave it to your interests & sense of fairness what to pick which one(s) :)

1. https://lore.kernel.org/git/pull.1012.v2.git.git.1623329868.gitgitgadget@gmail.com/
2. https://lore.kernel.org/git/8735sydvzs.fsf@evledraar.gmail.com/