git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Jun 2021, #07; Wed, 30)

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jul 6, 2021, 19:29 UTC
Message-ID
<87k0m35jfi.fsf@evledraar.gmail.com>
In-Reply-To
<d04c71fe-acfb-abe0-b00f-cfa01651dd57@gmail.com>
On Tue, Jul 06 2021, Phillip Wood wrote:
Show 26 quoted lines
> On 03/07/2021 06:04, Elijah Newren wrote:
>> On Wed, Jun 30, 2021 at 3:58 PM Junio C Hamano <gitster@pobox.com> wrote:
>>> * pw/diff-color-moved-fix (2021-06-15) 10 commits
>>>   - diff --color-moved: intern strings
>>>   - diff --color-moved-ws=allow-indentation-change: improve hash lookups
>>>   - diff --color-moved: stop clearing potential moved blocks
>>>   - diff --color-moved: shrink potential moved blocks as we go
>>>   - diff --color-moved: unify moved block growth functions
>>>   - diff --color-moved: call comparison function directly
>>>   - diff --color-moved-ws=allow-indentation-change: simplify and optimize
>>>   - diff: simplify allow-indentation-change delta calculation
>>>   - diff --color-moved: avoid false short line matches and bad zebra coloring
>>>   - diff --color-moved=zebra: fix alternate coloring
>>>
>>>   Long-overdue correctness and performance update to "diff
>>>   --color-moved" feature.
>>>
>>>   Waiting for reviews.
>> I read through the first half the patches or so and didn't spot
>> anything wrong, though I'm very unfamiliar with this code area and
>> don't yet understand much of what's going on; it was more of a spot
>> check.  I'll try to get back to it again, but my review probably won't
>> be that deep.
>
> Thanks for taking a look, do let me know if I can do anything to make
> reviewing this series easier
FWIW I put it on my own mental list of "waiting for re-roll" per [1].

(Not that you need to take my suggestion there, just that you seemed to agree, so I thought I'd take a look when that happened in a v2).

1. https://lore.kernel.org/git/094f5e5f-d447-8867-a9a7-be5c8827bba6@gmail.com/
Previous: Phillip WoodNext: Junio C Hamano
Message 15 of 18 in “What's cooking in git.git (Jun 2021, #07; Wed, 30)”
  1. Junio C HamanoJun 30, 2021
  2. Felipe ContrerasJul 1, 2021
  3. Ævar Arnfjörð BjarmasonJul 1, 2021
  4. Jeff HostetlerJul 1, 2021
  5. Ævar Arnfjörð BjarmasonJul 1, 2021
  6. Junio C HamanoJul 1, 2021
  7. Ævar Arnfjörð BjarmasonJul 2, 2021
  8. Junio C HamanoJul 2, 2021
  9. Jeff KingJul 1, 2021
  10. Jeff KingJul 1, 2021
  11. Elijah NewrenJul 3, 2021
  12. Ævar Arnfjörð BjarmasonJul 5, 2021
  13. Jeff KingJul 5, 2021
  14. Phillip WoodJul 6, 2021
  15. Ævar Arnfjörð BjarmasonJul 6, 2021
  16. Junio C HamanoJul 6, 2021
  17. Han-Wen NienhuysJul 1, 2021
  18. Ævar Arnfjörð BjarmasonJul 1, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.