Re: What's cooking in git.git (Jun 2021, #07; Wed, 30)

From: Jeff King <peff@peff.net>
Date: Jul 1, 2021, 16:51 UTC
Message-ID: <YN3ygh98zikMmd1S@coredump.intra.peff.net>
In-Reply-To: <87o8bmcd9a.fsf@evledraar.gmail.com>

On Thu, Jul 01, 2021 at 04:00:01PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 13 quoted lines

> > * ab/serve-cleanup (2021-06-28) 8 commits
> >  - upload-pack.c: convert to new serve.c "startup" config cb
> >  - serve: add support for a "startup" git_config() callback
> >  - serve.c: add trace2 regions for advertise & command
> >  - serve.c: add call_{advertise,command}() indirection
> >  - serve: use designated initializers
> >  - transport: use designated initializers
> >  - transport: rename "fetch" in transport_vtable to "fetch_refs"
> >  - serve: mark has_capability() as static
> >
> >  Code clean-up around "git serve".
> 
> Jeff, what do you think about this version & the upload-pack.c changes?

I left some comments on the config-callback patches. I think it's an OK direction.

I didn't read the final patch carefully. And I do think it needs to be gone over very carefully to make sure there are not any subtleties, given the problems we've had with config-reading there in the past. I'm not enthused about doing so for what I consider to be a pretty unexciting outcome. I.e., it feels a bit like high-risk churn for low reward.

-Peff