git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/4] Fix handling of remotes with single-character names

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Jul 28, 2015, 21:08 UTC
Message-ID
<cover.1438117334.git.mhagger@alum.mit.edu>

The parsing of `remotes.<groupname>` was broken if any of the remotes in the group has a name consisting of a single character.

The first patch fixes the bug; the others are general refactoring to make the function a little bit clearer.

This series is based on maint, which I just noticed is still v2.4.7, but it also rebases cleanly to master. It might make sense to apply only the first patch to maint and the others only to master.

These patches are also available from my GitHub repository [1] as branch "single-character-remotes".

Michael
[1] https://github.com/mhagger/git
Michael Haggerty (4):
  get_remote_group(): handle remotes with single-character names
  get_remote_group(): rename local variable "space" to "wordlen"
  get_remote_group(): eliminate superfluous call to strcspn()
  get_remote_group(): use skip_prefix()
 builtin/fetch.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)
-- 
2.4.6
Next: Michael Haggerty
Message 1 of 7 in “Fix handling of remotes with single-character names”
  1. 0/4 Fix handling of remotes with single-character namesMichael Haggerty, Jul 28, 2015
  2. 1/4 get_remote_group(): handle remotes with single-character namesMichael Haggerty, Jul 28, 2015
  3. 2/4 get_remote_group(): rename local variable "space" to "wordlen"Michael Haggerty, Jul 28, 2015
  4. 3/4 get_remote_group(): eliminate superfluous call to strcspn()Michael Haggerty, Jul 28, 2015
  5. 4/4 get_remote_group(): use skip_prefix()Michael Haggerty, Jul 28, 2015
  6. Junio C HamanoJul 30, 2015
  7. Michael HaggertyJul 31, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.