[PATCH 3/4] get_remote_group(): eliminate superfluous call to strcspn()
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Jul 28, 2015, 21:08 UTC
- Message-ID
- <441622b3d894ab73de159d55176f485d7c56b147.1438117334.git.mhagger@alum.mit.edu>
- In-Reply-To
- <cover.1438117334.git.mhagger@alum.mit.edu>
There is no need to call it if value is the empty string. This also eliminates code duplication.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> --- builtin/fetch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c index d0d267b..bd945d0 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -978,13 +978,13 @@ static int get_remote_group(const char *key, const char *value, void *priv) if (starts_with(key, "remotes.") && !strcmp(key + 8, g->name)) { /* split list by white space */ - size_t wordlen = strcspn(value, " \t\n"); while (*value) { + size_t wordlen = strcspn(value, " \t\n"); + if (wordlen >= 1) string_list_append(g->list, xstrndup(value, wordlen)); value += wordlen + (value[wordlen] != '\0'); - wordlen = strcspn(value, " \t\n"); } }
-- 2.4.6