[PATCH 1/4] get_remote_group(): handle remotes with single-character names
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Jul 28, 2015, 21:08 UTC
- Message-ID
- <9607497fedac5b69b76f6f47886b533553857ddb.1438117334.git.mhagger@alum.mit.edu>
- In-Reply-To
- <cover.1438117334.git.mhagger@alum.mit.edu>
The code for splitting a whitespace-separated list of values in "remotes.<name>" had an off-by-one error that caused it to skip over remotes whose names consist of a single character.
Also remove unnecessary braces.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> --- builtin/fetch.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c index f951265..98f9048 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -980,10 +980,9 @@ static int get_remote_group(const char *key, const char *value, void *priv) /* split list by white space */ int space = strcspn(value, " \t\n"); while (*value) { - if (space > 1) { + if (space >= 1) string_list_append(g->list, xstrndup(value, space)); - } value += space + (value[space] != '\0'); space = strcspn(value, " \t\n"); }
-- 2.4.6