git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] get_remote_group(): rename local variable "space" to "wordlen"

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Jul 28, 2015, 21:08 UTC
Message-ID
<3cb456d351a8af61a3ba894ba47aa5d7f32ed246.1438117334.git.mhagger@alum.mit.edu>
In-Reply-To
<cover.1438117334.git.mhagger@alum.mit.edu>
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 builtin/fetch.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c
index 98f9048..d0d267b 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -978,13 +978,13 @@ static int get_remote_group(const char *key, const char *value, void *priv)
 	if (starts_with(key, "remotes.") &&
 			!strcmp(key + 8, g->name)) {
 		/* split list by white space */
-		int space = strcspn(value, " \t\n");
+		size_t wordlen = strcspn(value, " \t\n");
 		while (*value) {
-			if (space >= 1)
+			if (wordlen >= 1)
 				string_list_append(g->list,
-						   xstrndup(value, space));
-			value += space + (value[space] != '\0');
-			space = strcspn(value, " \t\n");
+						   xstrndup(value, wordlen));
+			value += wordlen + (value[wordlen] != '\0');
+			wordlen = strcspn(value, " \t\n");
 		}
 	}
 
-- 
2.4.6
Previous: Michael HaggertyNext: Michael Haggerty
Message 3 of 7 in “Fix handling of remotes with single-character names”
  1. 0/4 Fix handling of remotes with single-character namesMichael Haggerty, Jul 28, 2015
  2. 1/4 get_remote_group(): handle remotes with single-character namesMichael Haggerty, Jul 28, 2015
  3. 2/4 get_remote_group(): rename local variable "space" to "wordlen"Michael Haggerty, Jul 28, 2015
  4. 3/4 get_remote_group(): eliminate superfluous call to strcspn()Michael Haggerty, Jul 28, 2015
  5. 4/4 get_remote_group(): use skip_prefix()Michael Haggerty, Jul 28, 2015
  6. Junio C HamanoJul 30, 2015
  7. Michael HaggertyJul 31, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.