Re: [PATCH v2 3/5] scalar: remove stale config values

From: Matthew Hughes <matthewhughes934@gmail.com>
Date: Dec 1, 2025, 17:46 UTC
Message-ID: <ciegbs72xbepxawuf42pne7eu354ntbok5e3p6jxcuyddvaea2@6ykt3iej32xt>
In-Reply-To: <8783db6153875deb52aaa354da189ae611de1057.1764607847.git.gitgitgadget@gmail.com>

On Mon, Dec 01, 2025 at 04:50:45PM +0000, Derrick Stolee via GitGitGadget wrote:

> * core.preloadIndex: This value is true by default, now. Removing this
>   causes some changes required to the tests that checked this config
>   value. Use gui.gcwarning=false instead.

I was going to ask about if we could also rely on the default value of index.threads like we do here, but then went and did some reading and realised some config values, like index.recordOffsetTable, have their value set according to whether index.threads was explicitly set, so I guess there's an implicit reliance on that behaviour that we want to keep?

Show 18 quoted lines

> * core.fscache: This config does not exist in the core Git project, but
>   is instead a config option for a Git for Windows feature.
> 
> * core.multiPackIndex: This config value is now enabled by default, so
>   does not need to be called out specifically. It was originally
>   included to make sure the background maintenance that created
>   multi-pack-indexes would result in the expected performance
>   improvements.
> 
> * credential.validate: This option is not something specific to Git but
>   instead an older version of Git Credential Manager for Windows. That
>   software was replaced several years ago by the cross-platform Git
>   Credential Manger so this option is no longer needed to help users who
>   were on that older software.
> 
> * pack.useSparse=true: This value is now Git's default as of de3a864114
>   (config: set pack.useSparse=true by default, 2020-03-20) so we don't
>   need it set by Scalar.

Thanks for the detail on all of these, very helpful