[PATCH 2/5] scalar: use index.skipHash=true for performance
- From
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Nov 26, 2025, 22:18 UTC
- Message-ID
- <1c51dbb81485920e9faf336ffbda9d9258e7dfe1.1764195516.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.2010.git.1764195516.gitgitgadget@gmail.com>
From: Derrick Stolee <stolee@gmail.com>
The index.skipHash config option has been set to 'false' by Scalar since 4933152cbb (scalar: enable path-walk during push via config, 2025-05-16) but that commit message is trying to communicate the exact opposite: that the 'true' value is what we want instead. This means that we've been disabling this performance benefit for Scalar repos unintentionally.
Fix this issue before we add justification for the config options set in this list.
Oddly, enabling index.skipHash causes a test issue during 'test_commit' in one of the Scalar tests when GIT_TEST_SPLIT_INDEX is enabled (as caught by the linux-test-vars build). I'm fixing the test by disabling the environment variable, but the issue should be resolved in a series focused on the split index.
Signed-off-by: Derrick Stolee <stolee@gmail.com> --- scalar.c | 2 +- t/t9210-scalar.sh | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/scalar.c b/scalar.c index 431b631585..75fd292be7 100644 --- a/scalar.c +++ b/scalar.c @@ -154,7 +154,7 @@ static int set_recommended_config(int reconfigure) { "credential.validate", "false", 1 }, /* GCM4W-only */ { "gc.auto", "0", 1 }, { "gui.GCWarning", "false", 1 }, - { "index.skipHash", "false", 1 }, + { "index.skipHash", "true", 1 }, { "index.threads", "true", 1 }, { "index.version", "4", 1 }, { "merge.stat", "false", 1 }, diff --git a/t/t9210-scalar.sh b/t/t9210-scalar.sh index 43c210a23d..91d5964b73 100755 --- a/t/t9210-scalar.sh +++ b/t/t9210-scalar.sh @@ -246,6 +246,11 @@ test_expect_success 'scalar reconfigure --all with includeIf.onbranch' ' ' test_expect_success 'scalar reconfigure --all with detached HEADs' ' + # This test demonstrates an issue with index.skipHash=true and + # this test variable for the split index. Disable the test variable. + GIT_TEST_SPLIT_INDEX= && + export GIT_TEST_SPLIT_INDEX && + repos="two three four" && for num in $repos do
-- gitgitgadget