Re: [PATCH v2 3/5] scalar: remove stale config values

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 2, 2025, 07:53 UTC
Message-ID: <aS6bCU19x-QM84tp@pks.im>
In-Reply-To: <ciegbs72xbepxawuf42pne7eu354ntbok5e3p6jxcuyddvaea2@6ykt3iej32xt>

On Mon, Dec 01, 2025 at 05:46:46PM +0000, Matthew Hughes wrote:

Show 10 quoted lines

> On Mon, Dec 01, 2025 at 04:50:45PM +0000, Derrick Stolee via GitGitGadget wrote:
> > * core.preloadIndex: This value is true by default, now. Removing this
> >   causes some changes required to the tests that checked this config
> >   value. Use gui.gcwarning=false instead.
> 
> I was going to ask about if we could also rely on the default value of
> index.threads like we do here, but then went and did some reading and realised
> some config values, like index.recordOffsetTable, have their value set
> according to whether index.threads was explicitly set, so I guess there's an
> implicit reliance on that behaviour that we want to keep?

Wait. Are you saying that "index.recordOffsetTable" behaves differently based on whether "index.threads" is implicitly enabled due to the default value or explicitly enabled via the configuration? If so, that smells like a plain bug to me.

Patrick