Re: [PATCHv6 8/8] gitweb: add avatar in signoff lines
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Jun 27, 2009, 10:21 UTC
- Message-ID
- <cb7bb73a0906270321m6154e6a2l240723ffbd7b6e8f@mail.gmail.com>
- In-Reply-To
- <200906271126.38757.jnareb@gmail.com>
2009/6/27 Jakub Narebski <jnareb@gmail.com>:
Show 8 quoted lines
> On Thu, 25 June 2009, Giuseppe Bilotta wrote:
>
>> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
>
> BTW. if it is an RFC, it should be marked as RFC in subject
> ("[RFC PATCHv6 8/8] gitweb: add avatar in signoff lines").
>
> And I guess this issue should be left for later.You're right. My next patchset will not include this part (I'll send it separately).
Show 8 quoted lines
>> I can't say I'm really satisfied with the layout given by this patch. >> A significant improvement could be obtained by turning the signoff >> line block into a table with three/four columns (signoff, name, >> email/avatar). > > First, I think adding (gr)avatars to signoff lines might be not worth > it. Neither GitHub nor Gitorious show gravatars for signoff lines > (note that they use larger images, and therefore easier to view).
Well, just because the others don't do it, it doesn't mean we shouldn't either ;-)
But yes, I have to confess I love toying around like this.
Show 17 quoted lines
> Second, it is not the only possible layout. Let's use one of existing > commits (e1d3793) in git repository as example: > > completion: add --thread=deep/shallow to format-patch > > [1] Signed-off-by: Stephen Boyd <bebarino@gmail.com> [2] [3] [4]| > [1] Trivially-Acked-By: Shawn O. Pearce <spearce@spearce.org> [2] [3] [4]| > [1] Signed-off-by: Junio C Hamano <gitster@pobox.com> [2] [3] [4]| > > Even without changing layout of signoff lines (so they look exactly > like they look in git-show or git-log output, modulo highlighting > and (gr)avatars), there are more possibilities: > > 1. On the left side of signoff lines > 2. Current version: on the right side of signoff lines, just after > 3. On the right hand side, aligned; would probably need table > 4. On the right hand side, flushed (floated) right
I have a table implementation running @ http://git.oblomov.eu/git/commit/e1d3793
Show 6 quoted lines
> There is also more complicated solution of having (gr)avatars appear > only on mouseover, either all avatars on hover over signoff block, > or single (and perhaps larger size) avatar on hover over signoff line. > This can be done using pure CSS, without JavaScript[1] > > [1] http://meyerweb.com/eric/css/edge/popups/demo2.html
Oh, that'd be an interesting variant. Straightforward to implement in the table case, too.
Show 16 quoted lines
> And here is version with (gr)avatar on the left side of signoff lines
> (take a look if it is not better layout):
>
> diff --git c/gitweb/gitweb.perl w/gitweb/gitweb.perl
> index 301bdd8..7701bac 100755
> --- c/gitweb/gitweb.perl
> +++ w/gitweb/gitweb.perl
> @@ -3407,6 +3407,8 @@ sub git_print_log {
> $signoff = 1;
> $empty = 0;
> if (! $opts{'-remove_signoff'}) {
> + my ($email) = $line =~ /<(\S+@\S+)>/;
> + print git_get_avatar($email, 'pad_after' => 1) if $email;
> print "<span class=\"signoff\">" . esc_html($line) . "</span><br/>\n";
> next;
> } else {I think that putting them aligned on the right is somewhat better because both in commit(diff) and in log view the author/committer avatar is already on the right.
-- Giuseppe "Oblomov" Bilotta