Re: [PATCHv6 1/8] gitweb: refactor author name insertion
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jun 25, 2009, 23:01 UTC
- Message-ID
- <200906260101.28054.jnareb@gmail.com>
- In-Reply-To
- <200906260055.11347.jnareb@gmail.com>
On Fri, 26 June 2009, Jakub Narebski wrote:
> On Thu, 25 June 2009, Giuseppe Bilotta wrote:
Show 16 quoted lines
> > @@ -5094,9 +5127,9 @@ sub git_log {
> > " | " .
> > $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree") .
> > "<br/>\n" .
> > - "</div>\n" .
> > - "<i>" . esc_html($co{'author_name'}) . " [$ad{'rfc2822'}]</i><br/>\n" .
> > "</div>\n";
> > + git_print_authorship(\%co);
> > + print "<br/>\n</div>\n";
> >
> > print "<div class=\"log_body\">\n";
> > git_print_log($co{'comment'}, -final_empty_line=> 1);
>
> Here you replace inline <i> element with <div> _block_ element,
> destroying layout. Replacing default of 'div' by default of
> inline <span> element restores old layout.Note: here we want <span>.
Show 9 quoted lines
> > @@ -5579,7 +5595,7 @@ sub git_commitdiff {
> > git_header_html(undef, $expires);
> > git_print_page_nav('commitdiff','', $hash,$co{'tree'},$hash, $formats_nav);
> > git_print_header_div('commit', esc_html($co{'title'}) . $ref, $hash);
> > - git_print_authorship(\%co);
> > + git_print_authorship(\%co, 'localtime' => 1);
> > print "<div class=\"page_body\">\n";
> > if (@{$co{'comment'}} > 1) {
> > print "<div class=\"log\">\n";Note: here we want <div>.
Whether default would be 'span' or 'div', at least one of those has to pass explicit 'tag' / '-tag' parameter. I guess it would be easier to pass 'tag' => 'span' in git_log().
-- Jakub Narebski Poland