Re: [PATCHv6 2/8] gitweb: uniform author info for commit and commitdiff

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Jun 26, 2009, 17:52 UTC
Message-ID: <cb7bb73a0906261052i4315075ag3f8e2ce220b8534e@mail.gmail.com>
In-Reply-To: <200906260114.44345.jnareb@gmail.com>

2009/6/26 Jakub Narebski <jnareb@gmail.com>:

Show 14 quoted lines

> On Thu, 25 June 2009, Giuseppe Bilotta wrote:
>
> Here I would write that 'commitdiff' view moves from
>
>  Giuseppe Bilotta [Mon, 22 Jun 2009 22:49:58 +0000 (00:49 +0200)]
>
> to
>
>  author      Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
>              Mon, 22 Jun 2009 22:49:58 +0000 (00:49 +0200)
>  committer   Jakub Narebski <jnareb@gmail.com>
>              Tue, 23 Jun 2009 18:02:21 +0000 (20:02 +0200)"
>
> (perhaps with A U Thor and C O Mitter as example names).

Done.

Show 7 quoted lines

> Very good that you put this in separate patch, so it can be evaluated
> independently, and decided independently whether it is worth having more
> detailed authorship information in 'commitdiff', making it more like
> 'commit' view, or be more like 'log' view with similar, but slightly
> extended authorship information.
>
> I personally am a bit ambivalent about this issue...

I really don't understand why commit and commitdiff are so different, but this is something we went over already. One thing that should be kept in mind is that commitdiff can span multiple commits, but in this case it only display the information about the first one (but this is not something that is changed by my patch). commitdiff view probably needs a complete rethinking.

-- 
Giuseppe "Oblomov" Bilotta