Re: [PATCHv6 2/8] gitweb: uniform author info for commit and commitdiff
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jun 25, 2009, 23:14 UTC
- Message-ID
- <200906260114.44345.jnareb@gmail.com>
- In-Reply-To
- <1245926587-25074-3-git-send-email-giuseppe.bilotta@gmail.com>
On Thu, 25 June 2009, Giuseppe Bilotta wrote:
Here I would write that 'commitdiff' view moves from
Giuseppe Bilotta [Mon, 22 Jun 2009 22:49:58 +0000 (00:49 +0200)]
to
author Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Mon, 22 Jun 2009 22:49:58 +0000 (00:49 +0200)
committer Jakub Narebski <jnareb@gmail.com>
Tue, 23 Jun 2009 18:02:21 +0000 (20:02 +0200)"(perhaps with A U Thor and C O Mitter as example names).
Show 22 quoted lines
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> ---
> gitweb/gitweb.perl | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 9b60418..cdfd1d5 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -5595,7 +5595,11 @@ sub git_commitdiff {
> git_header_html(undef, $expires);
> git_print_page_nav('commitdiff','', $hash,$co{'tree'},$hash, $formats_nav);
> git_print_header_div('commit', esc_html($co{'title'}) . $ref, $hash);
> - git_print_authorship(\%co, 'localtime' => 1);
> + print "<div class=\"title_text\">\n" .
> + "<table class=\"object_header\">\n";
> + git_print_full_authorship(\%co);
> + print "</table>".
> + "</div>\n";
> print "<div class=\"page_body\">\n";
> if (@{$co{'comment'}} > 1) {
> print "<div class=\"log\">\n";Nice and short thanks to refactoring you have done in previous patch.
Very good that you put this in separate patch, so it can be evaluated independently, and decided independently whether it is worth having more detailed authorship information in 'commitdiff', making it more like 'commit' view, or be more like 'log' view with similar, but slightly extended authorship information.
I personally am a bit ambivalent about this issue...
> -- > 1.6.3.rc1.192.gdbfcb > >
-- Jakub Narebski Poland