Re: [PATCH v4] json_writer: new routines to create data in JSON format
- From
Ramsay Jones <ramsay@ramsayjones.plus.com>
- Date
- Mar 27, 2018, 18:05 UTC
- Message-ID
- <c9c2ebba-9cde-9eed-bd08-34ce8b543787@ramsayjones.plus.com>
- In-Reply-To
- <2bc6f6a6-bf53-b87c-af02-156ad006a878@jeffhostetler.com>
On 27/03/18 18:14, Jeff Hostetler wrote:
Show 20 quoted lines
> > > On 3/27/2018 11:45 AM, Ramsay Jones wrote: >> >> >> On 27/03/18 04:18, Ramsay Jones wrote: >>> On 26/03/18 15:31, git@jeffhostetler.com wrote: >>>> From: Jeff Hostetler <jeffhost@microsoft.com> >>>> >>> [snip] >>> >>> Thanks, this version fixes all issues I had (with the compilation >>> and sparse warnings). >>> >>> [Was using UINT64_C(0xffffffffffffffff) a problem on windows?] >> >> BTW, I forgot to mention that you had some whitespace problems >> with this patch, viz: > > I ran "make sparse" on this and it did not complain about any of this.
No, sparse doesn't check for whitespace issues.
> What command do you run to get these messages?
'git am' told me when I applied the patch from the ML, and ...
> I know they appear as red in diffs (and I usually double check that), > but I had not seen a command to complain about them like this.
... since I applied the patch yesterday, it was easier to demonstrate the issue today using this command:
Show 13 quoted lines
>> $ git log --oneline -1 --check master-json >> ab643d838 (master-json) json_writer: new routines to create data in JSON format >> t/helper/test-json-writer.c:280: trailing whitespace. >> + */ >> t/t0019-json-writer.sh:179: indent with spaces. >> + "g": 0, >> t/t0019-json-writer.sh:180: indent with spaces. >> + "h": 1 >> $ > > the leading spaces are required in this case. > the pretty json output contains 8 spaces for that sub-structure not a tab. > is there a preferred way to denote this in the test script?
OK, I should have looked at the output more closely! :(
Only the trailing whitespace in test-json-writer.c needs to be addressed then.
ATB, Ramsay Jones