Re: [PATCH v4] json_writer: new routines to create data in JSON format

From: Jeff King <peff@peff.net>
Date: Jun 2, 2018, 05:13 UTC
Message-ID: <20180602051344.GA28311@sigill.intra.peff.net>
In-Reply-To: <CACsJy8DcGp29iJDZKUz0JM-bvbE_G3KnqWyLk_efjd7T3URTYw@mail.gmail.com>

On Sat, Jun 02, 2018 at 06:41:06AM +0200, Duy Nguyen wrote:

Show 8 quoted lines

> On Mon, Mar 26, 2018 at 4:31 PM,  <git@jeffhostetler.com> wrote:
> > +static inline void assert_in_array(const struct json_writer *jw)
> > +{
> > +       if (!jw->open_stack.len)
> > +               die("json-writer: array: missing jw_array_begin()");
> 
> When you reroll, please consider marking all these string for
> translation with _(), unless these are for machine consumption.

Actually, these are all basically asserts, I think. So ideally they'd be BUG()s and not translated.

-Peff